Batch 5: Event system — thread safety, IUpdateEventListener, Progress events#370
Merged
Conversation
… events - Rewrite EventManager with ConcurrentDictionary for thread safety Each handler invoked individually so one handler's exception doesn't prevent others from being called. - Add IUpdateEventListener interface for batch registration of all 7 event types at once via AddEventListener<T>() - Add UpdateEventListenerBase abstract class for optional overrides - Add ProgressEventArgs and AddListenerProgress to Bootstrap - Wire DownloadProgressReporter to fire Progress/Completed/Error events through EventManager automatically - Fix test to match new OnProgress signature Closes #369
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Event system improvements: thread-safe EventManager, batch listener registration, and real-time progress events.
Changes
EventManager — thread safety fix
IUpdateEventListener — batch registration
ProgressEventArgs — real-time progress
DownloadProgressReporter bridge
Build
Closes #369